feat(developer): ldml scancodes 🙀

For: #9403 - read implied imports for scancodes
keymanapp · Sep 22, 2023 · 6a54ebd · 6a54ebd
1 parent 5ddc8c8
commit 6a54ebd
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/common/web/types/src/ldml-keyboard/ldml-keyboard-xml-reader.ts b/common/web/types/src/ldml-keyboard/ldml-keyboard-xml-reader.ts
@@ -49,6 +49,14 @@ export class LDMLKeyboardXMLSourceFileReader {
       if (!source.keyboard3.keys.import) {
         source.keyboard3.keys.import = [];
       }
+      if (!source.keyboard3.forms) {
+        source.keyboard3.forms = {
+          form: [],
+        };
+      }
+      if (!source.keyboard3.forms.import) {
+        source.keyboard3.forms.import = [];
+      }
     }
     boxXmlArray(source?.keyboard3, 'layers');
     boxXmlArray(source?.keyboard3?.displays, 'display');
@@ -152,6 +160,14 @@ export class LDMLKeyboardXMLSourceFileReader {
       })) {
         return false;
       }
+    } else if (subtag === 'forms') {
+      // <import base="cldr" path="techpreview/scanCodes-implied.xml"/>
+      if (!this.resolveOneImport(obj, subtag, {
+        base: constants.cldr_import_base,
+        path: constants.cldr_implied_forms_import
+      })) {
+        return false;
+      }
     }
     return true;
   }

diff --git a/core/include/ldml/keyboardprocessor_ldml.h b/core/include/ldml/keyboardprocessor_ldml.h
@@ -16,6 +16,7 @@
 #pragma once
 
 #define LDML_BKSP_FLAGS_ERROR 0x1
+#define LDML_CLDR_IMPLIED_FORMS_IMPORT "techpreview/scanCodes-implied.xml"
 #define LDML_CLDR_IMPLIED_KEYS_IMPORT "techpreview/keys-Latn-implied.xml"
 #define LDML_CLDR_IMPORT_BASE "cldr"
 #define LDML_CLDR_VERSION_LATEST "techpreview"

diff --git a/core/include/ldml/keyboardprocessor_ldml.ts b/core/include/ldml/keyboardprocessor_ldml.ts
@@ -74,6 +74,10 @@ class Constants {
    * implied keys file
    */
   readonly cldr_implied_keys_import = `${this.cldr_version_techpreview}/keys-Latn-implied.xml`;
+  /**
+   * implied scancodes file
+   */
+  readonly cldr_implied_forms_import = `${this.cldr_version_techpreview}/scanCodes-implied.xml`;
   /**
    * Length of a raw section header, in bytes
    */