-
-
Notifications
You must be signed in to change notification settings - Fork 111
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
For: #9403 - improve how forms are read in the XML structure - warnings when custom (non-default-import) scancodes are loaded - error, as usual, when an unknown form is present
- Loading branch information
Showing
7 changed files
with
98 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
developer/src/kmc-ldml/test/fixtures/sections/layr/error-custom-form.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
|
||
<!DOCTYPE keyboard3 SYSTEM "../../../../../../../resources/standards-data/ldml-keyboards/techpreview/dtd/ldmlKeyboard3.dtd"> | ||
<keyboard3 locale="und" conformsTo="techpreview"> | ||
<names> | ||
<name value="layr-error-custom-form" /> | ||
</names> | ||
|
||
<keys> | ||
<key id="grave" to="`" /> | ||
<key id="one" to="1" /> | ||
</keys> | ||
<forms> | ||
<!-- warning, custom scancodes --> | ||
<form id="zzz"> | ||
<scanCodes codes="01 02 03 04" /> | ||
</form> | ||
</forms> | ||
<layers form="zzz"> <!-- INVALID: 'zzz' is not a valid form. --> | ||
<layer id="base"> | ||
<row keys="grave one" /> | ||
</layer> | ||
</layers> | ||
</keyboard3> |
25 changes: 25 additions & 0 deletions
25
developer/src/kmc-ldml/test/fixtures/sections/layr/hint-custom-form.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
|
||
<!DOCTYPE keyboard3 SYSTEM "../../../../../../../resources/standards-data/ldml-keyboards/techpreview/dtd/ldmlKeyboard3.dtd"> | ||
<keyboard3 locale="und" conformsTo="techpreview"> | ||
<names> | ||
<name value="layr-hint-custom-form" /> | ||
</names> | ||
|
||
<keys> | ||
<key id="grave" to="`" /> | ||
<key id="one" to="1" /> | ||
</keys> | ||
<forms> | ||
<!-- warning, custom scancodes --> | ||
<form id="us"> | ||
<scanCodes codes="01 02 03 04" /> | ||
</form> | ||
</forms> | ||
<layers form="us"> <!-- INVALID: 'holographic' is not a valid form. --> | ||
<layer id="base"> | ||
<!-- beware: this is mapping ` and 1! --> | ||
<row keys="grave one" /> | ||
</layer> | ||
</layers> | ||
</keyboard3> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters