Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dakota_smsc] Initial submission of dakota_smsc keyboard #3267

Closed
wants to merge 3 commits into from

Conversation

butanial
Copy link

@butanial butanial commented Jan 2, 2025

No description provided.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

PLEASE NOTE: team capacity for review is limited in December 2024 and will resume in January 2025. We appreciate your patience.

@butanial
Copy link
Author

butanial commented Jan 2, 2025

Ready for review. Thank you!

@LornaSIL
Copy link
Contributor

LornaSIL commented Jan 6, 2025

Thanks for your pull request! It looks like there's a lot of duplicated files here which need removing and/or moving. In general, all your files should be under release/d/dakota_smsc. Also, you should NOT commit any files in the build folder.

So, I would like to see a new PR that only has these files:

release/d/dakota_smsc/HISTORY.md
release/d/dakota_smsc/LICENSE.md
release/d/dakota_smsc/README.md
release/d/dakota_smsc/dakota_smsc.kpj
release/d/dakota_smsc/source/dakota_smsc.ico
release/d/dakota_smsc/source/dakota_smsc.keyman-touch-layout
release/d/dakota_smsc/source/dakota_smsc.kmn
release/d/dakota_smsc/source/dakota_smsc.kps
release/d/dakota_smsc/source/dakota_smsc.kvks
release/d/dakota_smsc/source/readme.htm
release/d/dakota_smsc/source/welcome/welcome.htm
release/d/dakota_smsc/source/welcome/image024.gif
release/d/dakota_smsc/source/welcome/image026.gif
release/d/dakota_smsc/source/welcome/image028.gif
release/d/dakota_smsc/source/welcome/image030.gif
release/d/dakota_smsc/source/help/dakota_smsc.php

Don't include the various versions of kmn or kps or final.keyman-touch-layout, etc. If the one called "final" is really the correct file, then rename it to dakota_smsc.keyman-touch-layout.

  • In general I prefer to name the images a bit more meaningfully, but that's up to you.
  • The .php file is empty right now. That will need some work. That is the file that will be online for users to see the help for the keyboard. (If you don't want to do the php file, then the whole keyboard should be submitted under experimental instead because our requirements are less rigorous under that folder.)

That's probably enough feedback for now. I'd suggest you close this PR and open a new one when you are ready since there are so many changes required.

@butanial
Copy link
Author

butanial commented Jan 6, 2025

Thank you for your help Lorna. I will close this request, follow your instructions and try again.

@butanial butanial closed this Jan 6, 2025
@butanial butanial deleted the dakota_smsc branch January 6, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants