Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLP1 - Sanskrit keyboard #3265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Harshavardhan-Pandurangan

The Sanskrit Library Phonetic ASCII package includes two keyboards: one to enter Devanagari Unicode, the other to enter Roman Unicode with diacritics. These include all accents required for The R̥gveda. Both keymaps follow the Sanskrit Library ASCII encoding described in brief at https://sanskritlibrary.org/help-text.html, and in full in Linguistic Issues in Encoding Sanskrit, Appendix B available in a PDF linked to at the bottom of that webpage. The Romanization followed in the slp1_roman keyboard is ISO 15919 except e and o are represented as in IAST without the macron. Capital characters are obtained by wrapping the character sequence in curly brackets.

The Sanskrit Library Phonetic ASCII package includes two keyboards: one to enter Devanagari Unicode, the other to enter Roman Unicode with diacritics.  These include all accents required for The R̥gveda.  Both keymaps follow the Sanskrit Library ASCII encoding described in brief at https://sanskritlibrary.org/help-text.html, and in full in Linguistic Issues in Encoding Sanskrit, Appendix B available in a PDF linked to at the bottom of that webpage.  The Romanization followed in the slp1_roman keyboard is ISO 15919 except e and o are represented as in IAST without the macron.  Capital characters are obtained by wrapping the character sequence in curly brackets.
@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

PLEASE NOTE: team capacity for review is limited in December 2024 and will resume in January 2025. We appreciate your patience.

@Harshavardhan-Pandurangan
Copy link
Author

This is my first time here, could u pls help in identifying what potential issues could be limiting me, and how I could fix this.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jan 6, 2025

This one will need some more work.

  • The folder should be renamed slp1_deva

  • The files called times.ttf, Sanskrit2020.ttf and TheSanskritLibrary.png should be removed from the root folder where you have HISTORY.md, etc.

  • The slp1.kpj file will need renamed to slp1_deva.kpj

  • The slp1.kps will need renaming to slp1_deva.kps and all references to slp1_roman files should be removed.

  • These files need deleting from the PR:

    • slp1_roman.kmn
    • slp1_roman.kvks
    • slp1_roman.ico
    • times.ttf (we cannot allow this font since its license does not permit distribution) Make sure to update the .kps to not reference this font file.
  • I think the README.md, welcome.htm and readme.htm files should be updated to make it clear this is just the slp1_deva keyboard. However, you can mention the other keyboard and link to it. (I'll need to approve both keyboards at the same time.)

  • I have the same issue with Sanskrit2020.ttf. I'd like to add that to the shared folder and I'm suggesting we add the newer version (Sanskrit2020U.ttf) if that's acceptable to you.

  • If you wish, in the .kps file, under "Details" there is a "Related packages:" menu. You can add slp1_roman there. You can do the same on the other keyboard by adding slp1_deva. That will allow users to see that both packages are related.

@Harshavardhan-Pandurangan
Copy link
Author

Thanks for the suggestions. The package we developed was intended to install both the Deva (Devanagari) and Roman keyboards together, i.e., in a single package. Is that possible, or is it necessary to make a separate package for each keyboard? The other pull request I made is a stripped-down version of this pull request, without the Devanagari keyboard.
I had made note of the licensed fonts and will remove them, as well as changes regarding removing files from certain locations and version numbers in files.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jan 7, 2025

You will need to have a separate keyboard package for each keyboard. Then, if necessary, we could do a keyboard bundle that includes both keyboards, but that is something we are not encouraging anymore.

@LornaSIL
Copy link
Contributor

Is it possible for you to update Keyman Developer to version 17.0? We now require the .kps file to include a description field and version 16.0 doesn't give you the dialog for adding that? That's on the Details tab. We also need LICENSE.md to be added to the list of files and to the Details tab. If you cannot update to v 17.0 I can probably update the files online for you.

One other thing, can you open the .kmn and go to the On-Screen keyboard tab and Fill from Layoutkeyboard. Then commit the new .kvks file to this PR. That will give people the layout of the keyboard.

@Harshavardhan-Pandurangan
Copy link
Author

I have made most of the changes suggested in both the roman and deva PRs. Pls let me know of any other changes required for the completion. Also, I still am not sure of where to place the font and image files in the PR directories. Any help on this would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants