-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: links to the available version of docs #1755
base: master
Are you sure you want to change the base?
Conversation
…into addressing-404-google-console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure how to handle anchored links
@@ -167,10 +167,9 @@ The presence of this store also ensures that Caps Lock is handled correctly for | |||
KeymanWeb keyboards (see | |||
[#5460](https://github.com/keymanapp/keyman/issues/5460#issuecomment-966602098)). | |||
|
|||
## Virtual character keys {#virtual-character-keys} | |||
## Virtual character keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to update all the links to these anchors. This one corresponds to l.84
which might work if we change that to `(#toc-virtual-character-keys).
I'm not sure we want to change all the links this way though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @darcywong00. The changes of this PR shows this:
Do you mean adding {#toc-
in front of virtual-character-keys}
, not removing them entirely? Also, may I know what is I.84? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The abbreviation l.84 means "line 84" in the file (above).
keyboard, along with the specified modifier. [More info](#virtual-character-keys)
When I tried locally, clicking the "More info" links didn't work
I noticed the links in "On this page" did work though. And they had the toc- prefix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @darcywong00. I've seen the abbreviation once before but couldn't remember it.
Would this fix be appropriate? the {#virtual-character-keys} showed up like this if not removed.
I am trying {#virtual-character-keys} on "More info" but no success.
Only being scrolled to via clicking on "On this page", but the URL shows this:
http://help.keyman.com.localhost:8055/developer/language/guide/virtual-keys#toc-virtual-character-keys-virtual-character-keys-
I think #toc-virtual-character-keys
was assigned as an id
before converting to markdown.
Solving: keymanapp/keyman.com#415.
This PR is ready for review.