-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require HepMC3 for rivet #680
base: main
Are you sure you want to change the base?
Conversation
Actually, this works for
|
For completeness, this was fixed in https://gitlab.com/hepcedar/rivet/-/merge_requests/904/ (Thomas is already aware) |
4f89a7f
to
a9ee6a8
Compare
There will be a new rivet 3.1.11 patch release that has a fix for building it with HepMC 3.3. I think it's easiest to simply wait for that with this. ( |
I'll do an update in the next days and pick up all the latest versions, then rivet 4.X.X will be installed and we can add this. |
rivet 4.x.x will break thepeg / herwig. I am actually not sure whether this is already reflected in the spack packages. |
Hi @tmadlener, Rivet 3.1.11 and YODA 1.9.11 have now been released |
Nice, let me add them to upstream spack so that we can pick them up here to get this moving again. |
Upstream PR: spack/spack#48141 |
60b9ded
to
0224f0e
Compare
spack/spack#48142 will make sure to not fall into that issue accidentally |
BEGINRELEASENOTES
ENDRELEASENOTES
Discovered by @dirkzerwas and @apricePhy
This should be pretty trivial to include without triggering a rebuild of large parts of the stack (as far as I can tell it's
thepeg
andherwig3
). I have tested this locally and things work there.@jmcarcell can this be picked up for tomorrows nightlies?