Changes for the new nightlies #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Sep 23, 2024
| @@ -44,4 +44,4 @@ def cmake_args(self): | |||
| def setup_run_environment(self, env): | |||
| env.prepend_path("MARLIN_DLL", self.prefix.lib + "/libMarlinKinfit.so") | |||
| # Make it usable from ROOT | |||
| env.prepend_path("LD_LIBRARY_PATH", self.prefix.lib) | |||
| env.prepend_path("ROOT_LIBRARY_PATH", self.prefix.lib) | |||
There was a problem hiding this comment.
Is ROOT_LIBRARY_PATH a new thing that root uses for looking for dictionaries / libraries to load? Or is this a place where things can be put, but will not be loaded automatically?
There was a problem hiding this comment.
Not new but hard to spot. ROOT looks there so loading libMarlinKinFit.so will work as if it was in LD_LIBRARY_PATH. I'll move some paths over time from LD_LIBRARY_PATH to ROOT_LIBRARY_PATH.
jmcarcell
force-pushed
the
scratch
branch
2 times, most recently
from
922c671 to
721dde5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Featuring adding GCC 14 builds for AlmaLinux 9 and setting it to the default (that's the case already since this morning) and other changes and fixes.