Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running on SWAN by unsetting some environment variables #600

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Support running on SWAN by unsetting some environment variables #600

merged 2 commits into from
Jun 17, 2024

Conversation

jmcarcell
Copy link
Member

No description provided.

@jmcarcell jmcarcell requested a review from kjvbrt June 16, 2024 20:44
vvolkl
vvolkl reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd suggest to add a "Unsetting paths from LCG release for SWAN..." printout - it might help to debug issues for users that have some exotic setups and wonder where their Pythonpaths went.

@jmcarcell
Copy link
Member Author

I'm sure we will find such environments

@jmcarcell jmcarcell merged commit 4b3a97d into main Jun 17, 2024
5 checks passed
@jmcarcell jmcarcell deleted the swan branch June 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkl vvolkl vvolkl left review comments

@kjvbrt kjvbrt Awaiting requested review from kjvbrt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @vvolkl