-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for the new nightly builds from scratch #583
Merged
Changes from 55 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
ad7bc07
Update the latest commit
jmcarcell 1cd7fcb
Update compiler for alma9
jmcarcell 20b7ed8
Use a newer version for ROOT
jmcarcell 6f5165a
Fix string
jmcarcell 0c328e4
Fix compiler
jmcarcell e9c7e4a
Add a .cherry-pick file
jmcarcell 845314b
Fix cherry picks for whizard and madgraph
jmcarcell 9a3a8ae
Add a patch for babayaga
jmcarcell 9ebae75
Use version 3 of madgraph
jmcarcell c8d9739
Add gaudi v38.1
jmcarcell 9e3780b
Fix commit
jmcarcell 495d318
Add comment
jmcarcell 4896005
Add comment
jmcarcell bfa912c
Add fix for pythia 8.311
jmcarcell 09e6845
Change comment
jmcarcell 8e4678a
Add a cxxstd variant for fastjet
jmcarcell 6a89b92
Add cxxstd=20 with fastjet
jmcarcell 0cd2d93
Add a cxxstd variant for pythia8
jmcarcell 68af5b0
Fix cherry pick
jmcarcell c02398f
Add cxxstd=20 for pythia8
jmcarcell 810cb80
Add pythia8 to madgraph5amc
jmcarcell 860903a
Use cxxstd from ROOT in k4Clue
jmcarcell 35d8a69
Use the cxxstd from ROOT in k4MarlinWrapper
jmcarcell aeb0cfe
Simplify recipe
jmcarcell 10e0513
Fix style
jmcarcell 5ed2efb
Remove unneeded cxxstd=20
jmcarcell 1bcd797
Remove build_type=Release since it's the default
jmcarcell 76592f2
Update script
jmcarcell 6e6263c
Fix script
jmcarcell f9ef66e
Remove the remaining build_type=Release
jmcarcell 199b8b8
Fix version requirement
jmcarcell ab1ffd9
Clean up pandorapfa
jmcarcell fbe9a46
Clean up k4geo
jmcarcell b8d9196
Clean up larcontent
jmcarcell 2df24e1
Clean up fccanalyses
jmcarcell ea0befe
Fix recipe
jmcarcell 66d4445
Remove cxxstd=20 for ced
jmcarcell 00dab15
Remove a few unnecessary cxxstd=20
jmcarcell 5a6e211
Update order
jmcarcell f22f5cd
Add requirements for onnx, py-onnx and py-onnxruntime
jmcarcell 6f87d75
Add a madgraph+pythia test
jmcarcell 8a1b6dc
Change comment
jmcarcell df366c5
Build whizard with latex
jmcarcell f19224b
Update script
jmcarcell bddb97b
Go back to using multiple specs
jmcarcell a0dd06c
Build whizard with +openmp
jmcarcell d01d05b
Add a fix for the reconcretize issue
jmcarcell 5b67d6c
Go back to using a single spec
jmcarcell 89bb528
Comment also the spack block
jmcarcell 6670744
Add message about the nigtlies and CentOS 7
jmcarcell b487422
Change comment
jmcarcell 6e800b0
Add patchs for FCCAnalyses
jmcarcell c3b2f1a
Add patch for k4reccalorimeter
jmcarcell 5e2e31a
Fix sha256
jmcarcell f1ff3b7
Don't fail if the remote is already there
jmcarcell b28ade7
Build xrootd with the same cxxstd as ROOT
jmcarcell f4d5e02
Update setup scripts to work when there are multiple links in latest
jmcarcell d5118f9
Add a few comments
jmcarcell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
git remote add jmcarcell https://github.com/jmcarcell/spack || true | ||
git fetch jmcarcell -q | ||
|
||
# add a recent version of madgraph, remove when https://github.com/spack/spack/pull/41128 is merged | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/41128.diff | patch -p1 | ||
|
||
# add vdt for CPATH, needed for podio+rntuple | ||
git cherry-pick f97fabc3ff12527e5220ea6917719a73f8bd4315 -X theirs --no-commit | ||
|
||
# Add a patch to fix whizard (re pythia8), remove! | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/43045.diff | patch -p1 | ||
|
||
# podio: add rpath, remove when https://github.com/spack/spack/pull/42844 is merged | ||
git cherry-pick 4d3b81d73b9dcbbe176d6baf3c00a4032307f6a8 -X theirs --no-commit | ||
|
||
# gaudi: add missing std::list, remove when building 38.2 | ||
git cherry-pick 6b02e009664c6effb581023982dcb7863da5fb88 -X theirs --no-commit | ||
|
||
# gaudi: Add v38.1, remove! | ||
git cherry-pick 64df3df040c71ce2f31f718df1afb373bcf68368 -X theirs --no-commit | ||
|
||
# pythia8: Add fix for 8.311, remove when https://github.com/spack/spack/pull/43803 is merged | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/43803.diff | patch -p1 | ||
|
||
# fastjet: Add a cxxstd variant, remove! | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/44072.diff | patch -p1 | ||
|
||
# pythia8: Add a cxxstd, remove when https://github.com/spack/spack/pull/44077 is merged | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/44077.diff | patch -p1 | ||
|
||
# fix issues when reconcretizing a GitVersion? remove when https://github.com/spack/spack/pull/43859 is merged | ||
curl -s https://patch-diff.githubusercontent.com/raw/spack/spack/pull/43859.diff | patch -p1 | ||
|
||
# py-onnxruntime: Install the session headers, needed by FCCAnalyses | ||
git cherry-pick e272ffa5a4768d23f1579403f9872360630e7278 -X theirs --no-commit | ||
|
||
|
||
if [[ "$(grep -E '^ID=' /etc/os-release)" = 'ID="centos"' && "$(grep -E 'VERSION_ID' /etc/os-release)" = 'VERSION_ID="7"' ]]; then | ||
|
||
# patch for intel-tbb for CentOS 7, see https://github.com/oneapi-src/oneTBB/issues/859 | ||
# because we use binutils from the system which is old | ||
git cherry-pick d8a0b0426a1c97c33c4b8f133d38e7dc03816a8c -X theirs --no-commit | ||
|
||
# Make py-onnxruntime depend on git for CentOS 7 because the | ||
# system git is too old and fails at fetching, remove when https://github.com/spack/spack/pull/43076 is merged | ||
git cherry-pick b330252d082dc2865fa169af831b7b7c2affa8a5 -X theirs --no-commit | ||
|
||
fi | ||
|
||
if [[ "$(grep -E '^ID=' /etc/os-release)" = 'ID=ubuntu' && "$(grep -E 'VERSION_ID' /etc/os-release)" = 'VERSION_ID="22.04"' ]]; then | ||
|
||
# patch to rename libz so texlive can be built | ||
git cherry-pick f8c6f240ba9b99218eb72bfadce9f99952fec1de -X theirs --no-commit | ||
|
||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
12963c894f59bf03f2f8ab94536019d9f82d3527 | ||
f5946c4621035dd466953c8d2664ff5f82f38138 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you ever dig deeper in what is pulling in
6.28
if not asking for6.30
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope 😢
I also see ROOT rebuilding after reconcretizing with the same settings for some reason...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, same for me. In my case it could also be a changed dependency, but I haven't investigated any further yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it seems cxxstd of xrootd can be either 11 and 14 and sometimes it's one or the other even though nothing has changed. I'll try to hardcode it and see if it helps... It seems only to happen on alma9