Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup script #564

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix setup script #564

merged 2 commits into from
Feb 26, 2024

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Feb 26, 2024

BEGINRELEASENOTES

  • Fix for the setting of K4GEO env variable

ENDRELEASENOTES

@@ -175,7 +175,7 @@ k4_local_repo() {
export CMAKE_PREFIX_PATH=$PWD/$install:$CMAKE_PREFIX_PATH
export PKG_CONFIG_PATH=$PWD/$install/lib/pkgconfig:$PKG_CONFIG_PATH
export ROOT_INCLUDE_PATH=$PWD/$install/include:$ROOT_INCLUDE_PATH
if [ "$current_repo" "k4geo" ]; then
if [ "$current_repo" == "k4geo" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ "$current_repo" == "k4geo" ]; then
if [ "$current_repo" = "k4geo" ]; then

This works with other shells than bash, for example zsh

@jmcarcell
Copy link
Member

Indeed something went wrong when copying and pasting, this will be updated soon in cvmfs

@jmcarcell jmcarcell merged commit 0c4f5e5 into key4hep:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants