Remove explicit mentions of older variants #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit fixed with #528 |
jmcarcell
reviewed
Sep 11, 2023
tmadlener
changed the title
tmadlener
force-pushed
the
cleaner-root-spec
branch
from
6249be4 to
0aebed9
Compare
Co-authored-by: Juan Miguel Carceller <[email protected]>
tmadlener
force-pushed
the
cleaner-root-spec
branch
from
5fd931b to
8757028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few variants from the root spec that are only available
@:6.17. I just stumbled over this withspack@developin a local environment. If I switch thevarianttorequirespack would refuse to concretize if I add@6.28.06to the clause, because the variants "do not exist" in that case, and the conretizer is not able to see through that apparently.Since we are way ahead on root in any case, I think the easiest is to simply remove the three variants here.