-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCCeeMDI] Use absolute path to import CAD files #372
Conversation
This should work AIDASoft/DD4hep#1175 with recent enough DD4hep versions? 1.27 and newer |
I have opened an issue in DD4hep (AIDASoft/DD4hep#1313). Can we merge this regardless of the issue? I'd keep it like this even after the fix. |
I think this rather is an issue for key4hep-spack though. Because it comes down to ROOT with pcre2 (I think), which we have no control over in DD4hep. |
I see. Does this prevent merging this PR? |
Apart from the full path making it harder to changing the files and trying things out with ones own copy of a folder. No, nothing prevents merging these changes. |
By the way
Is this your interpretation of the TPRegexp error mentioned in the DD4hep issue, or was this a different error message that caused the conclusion written here? |
No no, it comes from the fact that running |
It does not work in the way that there is the TPRegex error? |
Yes |
BEGINRELEASENOTES
ENDRELEASENOTES
It looks like, when importing CAD file with
<shape type="CAD_MultiVolume" ref="path_to_stl_file" unit="mm" material="LiquidNDecane">
, the path is relative to where the ddsim command is launched