Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonise two noise tool interfaces #214

Merged
merged 4 commits into from
Jul 25, 2024
Merged

harmonise two noise tool interfaces #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e2b232
harmonise naming with ICaloReadCellNoiseMap
giovannimarchiori Jul 19, 2024
696f198
Merge branch 'key4hep:main' into gmarchio-main-20240719
giovannimarchiori Jul 19, 2024
4e1e450
fix pre-commit test error
giovannimarchiori Jul 19, 2024
829c755
implement comments from review
giovannimarchiori Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

/** @class ICaloReadCellNoiseMap RecInterface/RecInterface/ICaloReadCellNoiseMap.h ICaloReadCellNoiseMap.h
*
* Abstarct Interface to noise per Calorimeter cell.
* Abstract interface for tools that read noise values (RMS and offset) per calorimeter cell
*
* @author Coralie Neubueser
*/
Expand All @@ -36,4 +36,4 @@ class ICaloReadCellNoiseMap : virtual public IAlgTool {
virtual double noiseRMS(uint64_t aCellId) = 0;
virtual double noiseOffset(uint64_t aCellId) = 0;
};
#endif /* RECINTERFACE_ICALOREADNEIGHBOURSMAP_H */
#endif /* RECINTERFACE_ICALOREADCELLNOISEMAP_H */
2 changes: 1 addition & 1 deletion k4Interface/include/k4Interface/INoiseCaloCellsTool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

/** @class INoiseCaloCellsTool
*
* Abstract interface to calorimeter noise tool
* Abstract interface for tools that add or filter noise to calorimeter cells
*
* @author Jana Faltova
* @date 2016-09
Expand Down
6 changes: 3 additions & 3 deletions k4Interface/include/k4Interface/INoiseConstTool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

/** @class INoiseConstTool
*
* Abstract interface to get calorimeter noise per cell tool
* Abstract interface for tools that return noise values (RMS and offset) per calorimeter cell
* @author Coralie Neubueser
* @date 2018-01
*/
Expand All @@ -33,8 +33,8 @@ class INoiseConstTool : virtual public IAlgTool {
public:
DeclareInterfaceID(INoiseConstTool, 1, 0);

virtual double getNoiseConstantPerCell(uint64_t aCellID) = 0;
virtual double getNoiseOffsetPerCell(uint64_t aCellID) = 0;
virtual double getNoiseRMSPerCell(uint64_t aCellID) = 0;
virtual double getNoiseOffsetPerCell(uint64_t aCellID) = 0;
};

#endif /* RECINTERFACE_INOISECONSTTOOL_H */
Loading