telemetry: fix connected clients count

[ upstream commit e14bb5f1050924de1602033596d5b417bfbeee52 ]

Telemetry can only create 10 conns by default, each of which is processed
by a thread.

When a thread fails to write using socket, the thread will end directly
without reducing the total number of conns.

This will result in the machine running for a long time, and if there are
10 failures, the telemetry will be unavailable

Fixes: 2a7d0b8 ("telemetry: add upper limit on connections")
Cc: [email protected]

Signed-off-by: Shaowei Sun <[email protected]>
Acked-by: Bruce Richardson <[email protected]>
Acked-by: Ciara Power <[email protected]>
Acked-by: Chengwen Feng <[email protected]>

.mailmap

@@ -1232,6 +1232,7 @@ Shally Verma <[email protected]> <[email protected]>
 Shannon Nelson <[email protected]>
 Shannon Zhao <[email protected]>
 Shaopeng He <[email protected]>
+Shaowei Sun <[email protected]>
 Sharmila Podury <[email protected]>
 Sharon Haroni <[email protected]>
 Shay Agroskin <[email protected]>

lib/telemetry/telemetry.c

@@ -374,8 +374,8 @@ client_handler(void *sock_id)
 			"{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}",
 			telemetry_version, getpid(), MAX_OUTPUT_LEN);
 	if (write(s, info_str, strlen(info_str)) < 0) {
-		close(s);
-		return NULL;
+		TMTY_LOG(ERR, "Socket write base info to client failed\n");
+		goto exit;
 	}
 
 	/* receive data is not null terminated */
@@ -400,6 +400,7 @@ client_handler(void *sock_id)
 
 		bytes = read(s, buffer, sizeof(buffer) - 1);
 	}
+exit:
 	close(s);
 	__atomic_sub_fetch(&v2_clients, 1, __ATOMIC_RELAXED);
 	return NULL;