Skip to content

Commit

Permalink
power: fix log message when checking power modes
Browse files Browse the repository at this point in the history
Caught while inspecting changes backported in 21.11 LTS branch.
The POWER_LOG() macro in the main branch automatically appends a \n
which is not done by RTE_LOG().

Fixes: 393423d ("power: enable CPPC")

Reported-by: David Marchand <[email protected]>
Signed-off-by: Kevin Traynor <[email protected]>
  • Loading branch information
kevintraynor committed Dec 11, 2024
1 parent 2c27ed4 commit 28596b4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/power/rte_power_pmd_mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ check_scale(unsigned int lcore)
if (!rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ) &&
!rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ) &&
!rte_power_check_env_supported(PM_ENV_CPPC_CPUFREQ)) {
RTE_LOG(DEBUG, POWER, "Only ACPI, PSTATE, or CPPC modes are supported");
RTE_LOG(DEBUG, POWER, "Only ACPI, PSTATE, or CPPC modes are supported\n");
return -ENOTSUP;
}
/* ensure we could initialize the power library */
Expand All @@ -427,7 +427,7 @@ check_scale(unsigned int lcore)
env = rte_power_get_env();
if (env != PM_ENV_ACPI_CPUFREQ && env != PM_ENV_PSTATE_CPUFREQ &&
env != PM_ENV_CPPC_CPUFREQ) {
RTE_LOG(DEBUG, POWER, "Unable to initialize ACPI, PSTATE, or CPPC modes");
RTE_LOG(DEBUG, POWER, "Unable to initialize ACPI, PSTATE, or CPPC modes\n");
return -ENOTSUP;
}

Expand Down

0 comments on commit 28596b4

Please sign in to comment.