add comma after username to communicate with unicode

kevinptt0323 · Sep 30, 2017 · ff8ffda · ff8ffda
1 parent f83943d
commit ff8ffda
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/sites/ptt/bot.js b/src/sites/ptt/bot.js
@@ -100,7 +100,8 @@ class Bot extends EventEmitter {
 
   async login(username, password) {
     if (this._state.login) return;
-    await this.send(`${username}${key.Enter}${password}${key.Enter}`);
+    username = username.replace(/,/g, '');
+    await this.send(`${username},${key.Enter}${password}${key.Enter}`);
     let ret;
     while ((ret = await this._checkLogin()) === null) {
       await sleep(400);

diff --git a/test/connection.js b/test/connection.js
@@ -34,5 +34,16 @@ describe('Connection', () => {
         });
       });
     });
+    it('should login success with correct username (w/ trailing comma) and password', () => {
+      const ptt = new pttbot();
+      return new Promise((resolve, reject) => {
+        ptt.once('connect', () => {
+          ptt.login(username + ',', password)
+            .then(ret => assert.strictEqual(ret, true))
+            .then(resolve)
+            .catch(reject);
+        });
+      });
+    });
   });
 });