Make change_size function safer (sizing_2008) #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
change_size
in this PR:downto
andto
);However, there's a small problem with it. Line 299 now may cause a compilation warning (null range). The purpose of this line is to trigger a compilation error at synthesis stage (line 305) even if a synthesis tool ignored the
assert
on line 304. As a bonus, the error will be triggered on the line with the erroneous user's code, and not in sizing_2008.vhdl.If you know a way of avoiding the warning, please, let me know.
I was also thinking about moving the
change_size
functions into a separate file. Their purpose seems now to be too far from the other functions in sizing_2008. It was probably a mistake from me to add these functions in this file. Please, let me know what you think.