Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 2008 pipelining variant #4

Closed
alessandrothea opened this issue Nov 3, 2018 · 2 comments · May be fixed by #16
Closed

Missing 2008 pipelining variant #4

alessandrothea opened this issue Nov 3, 2018 · 2 comments · May be fixed by #16

Comments

@alessandrothea
Copy link

alessandrothea commented Nov 3, 2018 •
edited
Loading

Hi,

When compiling the master branch via makefile, the build stops at rtl/extras_2008/filtering.vhdl with the following error

###### rtl/extras_2008/filtering.vhdl(345): use extras_2008.pipelining.tapped_delay_line;
** Error (suppressible): rtl/extras_2008/filtering.vhdl(345): (vcom-1195) Cannot find expanded name "extras_2008.pipelining".
** Error: rtl/extras_2008/filtering.vhdl(345): Unknown expanded name.

Looks like pipelining_2008 is missing from the repository, isn't it?
@zacharyalutz
Copy link

Yes, I noticed this too. Provided that you don't need the FIR filter entity/architecture. you can comment it out from 'filtering.vhdl', since that is the only entity dependent on 'tapped_delay_line' from 'pipelining'.

@kevinpt: wondering if you have the source code written already for tapped_delay_line? If so, can you please check it into the repo, or if not can you describe the port-level behavior? I would be open to contributing if you are. Thanks!

@kevinpt
Copy link
Owner

kevinpt commented Jun 4, 2023

2008 Pipelining has been merged.

@kevinpt kevinpt closed this as completed Jun 4, 2023
This was referenced Jun 27, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dependency bug in fir_filter oswald3141/vhdl-extras
3 participants
@alessandrothea @kevinpt @zacharyalutz