Fixing async_camera_image signature & using extra_state_attributes
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is the actual fix: 77163ec [I force-pushed to clean it up] |
kevin-david
commented
Apr 10, 2022
| @@ -118,7 +118,7 @@ async def async_added_to_hass(self): | |||
| def _ready_for_snapshot(self, now): | |||
| return self._next_snapshot_at is None or now > self._next_snapshot_at | |||
|
|
|||
| async def async_camera_image(self): | |||
| async def async_camera_image(self, width: int | None = None, height: int | None = None): | |||
There was a problem hiding this comment.
This signature didn't work, this one does instead: 77163ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes marthoc#39 and marthoc#40
Found changes on blakeblackshear/frigate-hass-integration#145 and JurajNyiri/HomeAssistant-Tapo-Control#125
Not tested yet, need to install via HACS.