Create task for sync job status check #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: brian-mulier-p <[email protected]>
Co-authored-by: brian-mulier-p <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
Co-authored-by: Anna Geller <[email protected]>
brian-mulier-p
changed the base branch from
master
to
create-task-for-sync-job-status-check
brian-mulier-p
merged commit 7eeb715
into
kestra-io:create-task-for-sync-job-status-check
0 of 2 checks passed
brian-mulier-p
pushed a commit
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dbt task to check until job completed given a job run Id.
See discussion here
This would help reduce risks of failures / task resubmit generating an extra job when running long syncs.
Details:
Currently if Kestra worker fails at fetching the status when wait=True on this current plugin resubmitted task will trigger a new job instead of using the existing one
Flow will first trigger in a dedicated task, then “wait for status” will be done in a dedicated task.
If “wait for status” task fails (worker is dead / killed / pod restarted, this task can last for 10h+ so kind of likely) => task is resubmitted with the jobId to fetch for
No need for pod restart (due to k8s node upgrades for example) supervision