feat(ui) : Change edge type from smoothstep to bezier #5350
#5606
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stra-io#5350 changing edge type from `smoothstep` to `bezier`.
|
PR in ui-libs :kestro-io/ui-libs changes |
|
Hello @sanketmagar2001, unfortunately, the issue is still there : |
|
@sanketmagar2001 Hello, any update on this? |
|
Hi @Skraye, apologies for the delay 🙂. I was celebrating the festive season in our country, so I couldn't work on this during that time. |
|
We can also apply the approach 2 which I have mention : Calculate Edge Curvature and Offset , this may work as we can calculate the offset from the node . I will try this out , and let you know . will also update the PR once done. |
|
for now let's try with hard coded values , if this does not work . we can calculate the offset and curvature from source to target node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing edge type from
smoothsteptobezier.What changes are being made and why?
Changing edge type from 'smoothstep' to 'bezier' for more readable in complex dependency graph.
How the changes have been QAed?
Setup Instructions
Closes #5350.