Fix saving negative last damage to the entity #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minecraft uses the last damage stored on an entity to modify incoming damage that happens during the immunity tick with the formual `real-damage=input-damage - last damage`. When the last damage is negative the amount adds to the real damage taken and bypasses all damage reduction items like armor and effects like resistance. Steps to Reproduce Attack a player in full diamond armor with a sharpness 5 diamond sword while using a weakness 2 potion effect. Continue to attack the player until the potion effect expires. The player may suddenly die instead of taking normal diamond sword damage.
|
Under what circumstances would the |
I added steps to reproduce the bug. Attack a player in full diamond armor with a sharpness 5 diamond sword while using a weakness 2 potion effect. Continue to attack the player until the potion effect expires. The player may suddenly die instead of taking normal diamond sword damage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minecraft uses the last damage stored on an entity to modify incoming damage that happens during the immunity tick with the formula
real-damage=input-damage - last damage. When the last damage is negative the amount adds to the real damage taken and bypasses all damage reduction items like armor and effects like resistance.Steps to Reproduce
Attack a player in full diamond armor with a sharpness 5 diamond sword while using a weakness 2 potion effect. Continue to attack the player until the potion effect expires. The player may suddenly die instead of taking normal diamond sword damage.
config.yml.txt