Folia Support #720
Folia Support #720
Conversation
There was a problem hiding this comment.
Why is a whole separate class needed that just wraps other methods? Does folia not provide a better way of doing this?
There was a problem hiding this comment.
Folia does not provide a unified API. The method it provides to determine whether it is the folia only exists on the paper above 1.19.4, so there is currently no better way. The purpose of my separate encapsulation is for versatility.
src/main/java/kernitus/plugin/OldCombatMechanics/scheduler/SchedulerManager.java
Show resolved
Hide resolved
src/main/java/kernitus/plugin/OldCombatMechanics/scheduler/IScheduler.java
Outdated
Show resolved
Hide resolved
The adaptation on the folia side mainly lies in thread-related calls, and other APIs are basically implemented in the same way I do. |
| // BungeeCord Chat | ||
| compileOnly("net.md-5:bungeecord-chat:1.16-R0.4") |
There was a problem hiding this comment.
What is bungeecord chat needed for?
| compileOnly("org.spigotmc:spigot-api:1.20.3-R0.1-SNAPSHOT") | ||
| // compileOnly("org.spigotmc:spigot-api:1.20.3-R0.1-SNAPSHOT") | ||
| // Folia | ||
| compileOnly("dev.folia:folia-api:1.19.4-R0.1-20230527.192927-40@jar") |
There was a problem hiding this comment.
Did you actually manage to get this to build with Java 1.8? The github actions pipeline seems to fails to build this
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| /** | ||
| * Bukkit平台的调度器 |
There was a problem hiding this comment.
Could you translate this to english please
| import java.util.function.Consumer; | ||
|
|
||
| /** | ||
| * Folia平台的调度器 |
There was a problem hiding this comment.
Could you translate this to english please
| public interface ITaskWrapper { | ||
|
|
||
| /** | ||
| * 取消此任务 |
There was a problem hiding this comment.
Could you translate this to english please
|
@YufiriaMazenta is there a reason you closed the PR? |
I want to use another way to be compatible with folia |
Added Folia compatibility for plugin
#708