Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency of punctuation marks #64

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Fix inconsistency of punctuation marks #64

merged 1 commit into from
Mar 28, 2017

Conversation

Hakuyume
Copy link
Contributor

The documents are using both of 、。 style and ，． style.

@Hakuyume
Copy link
Contributor Author

Hakuyume commented Mar 28, 2017 •
edited
Loading

I found this PR is related to #40 .

@fchollet
Copy link
Collaborator

Wouldn't it be preferable to use 。 and 、 everywhere?

@Hakuyume
Copy link
Contributor Author

I think ，． is better because it is widely used in Japanese academic papers.
( @henry0312 mentioned ，． is better at #40 (comment) )

henry0312
henry0312 approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@henry0312 henry0312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit 54d663d into keras-team:master Mar 28, 2017
@Hakuyume Hakuyume deleted the fix-punctuation-marks branch March 28, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henry0312 henry0312 henry0312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hakuyume @fchollet @henry0312