Merge remote-tracking branch 'origin/candidate-9.8.x'

Signed-off-by: Gordon Smith <[email protected]> # Conflicts: # helm/hpcc/Chart.yaml # helm/hpcc/templates/_helpers.tpl # version.cmake
kenrowland · Aug 8, 2024 · f355d48 · f355d48
2 parents 473fcb7 + 4b02040
commit f355d48
Show file tree

Hide file tree

Showing 52 changed files with 718 additions and 441 deletions.
diff --git a/.github/workflows/build-assets.yml b/.github/workflows/build-assets.yml
@@ -245,7 +245,6 @@ jobs:
         with:
           name: html-help-documents
           path: |
-            ${{ needs.preamble.outputs.folder_build }}/docs/EN_US/EclipseHelp/*.zip
             ${{ needs.preamble.outputs.folder_build }}/docs/EN_US/HTMLHelp/*.zip
             ${{ needs.preamble.outputs.folder_build }}/docs/PT_BR/HTMLHelp/*.zip
           compression-level: 0
@@ -263,7 +262,7 @@ jobs:
             ${{ needs.preamble.outputs.folder_build }}/Release/docs/*.zip,
             ${{ needs.preamble.outputs.folder_build }}/Release/docs/EN_US/*.zip,
             ${{ needs.preamble.outputs.folder_build }}/Release/docs/PT_BR/*.zip,
-            ${{ needs.preamble.outputs.folder_build }}/docs/EN_US/EclipseHelp/*.zip,
+
             ${{ needs.preamble.outputs.folder_build }}/docs/EN_US/HTMLHelp/*.zip,
             ${{ needs.preamble.outputs.folder_build }}/docs/PT_BR/HTMLHelp/*.zip,
             ${{ needs.preamble.outputs.folder_build }}/*.md5sum

diff --git a/docs/BuildTools/cmake_config/EclipseHelp.txt b/docs/BuildTools/cmake_config/EclipseHelp.txt
diff --git a/docs/EN_US/CMakeLists.txt b/docs/EN_US/CMakeLists.txt
@@ -68,7 +68,6 @@ add_subdirectory(ECLProgrammersGuide)
 add_subdirectory(ECLStandardLibraryReference)
 add_subdirectory(ECLReference)
 
-add_subdirectory(EclipseHelp)
 add_subdirectory(HTMLHelp)
 add_subdirectory(ECLPlayground)
 add_subdirectory(HPCCClientTools)

diff --git a/docs/EN_US/EclipseHelp/CMakeLists.txt b/docs/EN_US/EclipseHelp/CMakeLists.txt
diff --git a/docs/EN_US/HPCCDataTutorial/DataTutorial.xml b/docs/EN_US/HPCCDataTutorial/DataTutorial.xml
@@ -955,13 +955,7 @@ DATASET('~tutorial::YN::TutorialPerson',
           </listitem>
 
           <listitem>
-            <para>Check the syntax, if no errors press the <emphasis
-            role="bold">Submit</emphasis> button.</para>
-          </listitem>
-
-          <listitem>
-            <para>When it completes, it displays a green checkmark
-            <inlinegraphic fileref="images/DT173-15.jpg" />.</para>
+            <para>Check the syntax, if no errors you can continue.</para>
           </listitem>
         </orderedlist>
       </sect2>
@@ -985,7 +979,7 @@ INDEX(TutorialYourName.File_TutorialPerson,{zip,fpos},'~tutorial::YN::PeopleByZi
           </listitem>
 
           <listitem>
-            <para>Check the syntax.</para>
+            <para>Check the syntax, if no errors you can continue.</para>
 
             <para>Next, we will build the index file.</para>
           </listitem>

diff --git a/ecl/eclagent/eclagent.ipp b/ecl/eclagent/eclagent.ipp
@@ -795,6 +795,7 @@ public:
 
     void ready();
     void execute() { if (!alreadyUpdated) activity->execute(); }
+    void onStart(const byte * parentExtract, CHThorDebugContext * debugContext);
     void stop() { if (!alreadyUpdated) activity->stop(); }
 
     IHThorException * makeWrappedException(IException * e);
@@ -829,6 +830,7 @@ public:
     CICopyArrayOf<EclGraphElement> dependentOnActivity;
     IntArray dependentControlId;
     IProbeManager * probeManager;
+    const byte * savedParentExtract = nullptr;
 
     Owned<EclBoundLoopGraph> loopGraph;
 };

diff --git a/ecl/eclagent/eclgraph.cpp b/ecl/eclagent/eclgraph.cpp
@@ -747,6 +747,24 @@ void EclGraphElement::ready()
         activity->ready();
 }
 
+void EclGraphElement::onStart(const byte * parentExtract, CHThorDebugContext * debugContext)
+{
+    savedParentExtract = parentExtract;
+    if (arg)
+    {
+        try
+        {
+            arg->onStart(parentExtract, NULL);
+        }
+        catch(IException * e)
+        {
+            if (debugContext)
+                debugContext->checkBreakpoint(DebugStateException, NULL, e);
+            throw makeWrappedException(e);
+        }
+    }
+}
+
 IHThorException * EclGraphElement::makeWrappedException(IException * e)
 {
     throw makeHThorException(kind, id, subgraph->id, e);
@@ -962,19 +980,7 @@ void EclSubGraph::doExecute(const byte * parentExtract, bool checkDependencies)
     ForEachItemIn(idx, elements)
     {
         EclGraphElement & cur = elements.item(idx);
-        if (cur.arg)
-        {
-            try
-            {
-                cur.arg->onStart(parentExtract, NULL);
-            }
-            catch(IException * e)
-            {
-                if (debugContext)
-                    debugContext->checkBreakpoint(DebugStateException, NULL, e);
-                throw cur.makeWrappedException(e);
-            }
-        }
+        cur.onStart(parentExtract, debugContext);
     }
 
     ForEachItemIn(ir, sinks)

diff --git a/ecl/hthor/hthor.cpp b/ecl/hthor/hthor.cpp
@@ -6719,13 +6719,13 @@ CHThorWhenActionActivity::CHThorWhenActionActivity(IAgentContext &_agent, unsign
 void CHThorWhenActionActivity::ready()
 {
     CHThorSimpleActivityBase::ready();
-    graphElement->executeDependentActions(agent, NULL, WhenBeforeId);
-    graphElement->executeDependentActions(agent, NULL, WhenParallelId);
+    graphElement->executeDependentActions(agent, graphElement->savedParentExtract, WhenBeforeId);
+    graphElement->executeDependentActions(agent, graphElement->savedParentExtract, WhenParallelId);
 }
 
 void CHThorWhenActionActivity::execute()
 {
-    graphElement->executeDependentActions(agent, NULL, 1);
+    graphElement->executeDependentActions(agent, graphElement->savedParentExtract, 1);
 }
 
 const void * CHThorWhenActionActivity::nextRow()
@@ -6735,7 +6735,7 @@ const void * CHThorWhenActionActivity::nextRow()
 
 void CHThorWhenActionActivity::stop()
 {
-    graphElement->executeDependentActions(agent, NULL, WhenSuccessId);
+    graphElement->executeDependentActions(agent, graphElement->savedParentExtract, WhenSuccessId);
     CHThorSimpleActivityBase::stop();
 }
 

diff --git a/esp/scm/ws_logaccess.ecm b/esp/scm/ws_logaccess.ecm
@@ -79,7 +79,8 @@ ESPenum LogColumnValueType : string
     str("string"),
     numeric("numeric"),
     datetime("datetime"),
-    enum("enum")
+    enum("enum"),
+    epoch("epoch")
 };
 
 ESPStruct [nil_remove] LogColumn

diff --git a/esp/services/ws_logaccess/WsLogAccessService.cpp b/esp/services/ws_logaccess/WsLogAccessService.cpp
@@ -71,6 +71,10 @@ bool Cws_logaccessEx::onGetLogAccessInfo(IEspContext &context, IEspGetLogAccessI
                                 WARNLOG("Invalid col type found in logaccess logmap config");
                             }
                         }
+                        else
+                        {
+                            espLogColumn->setColumnType("string");
+                        }
                         logColumns.append(*espLogColumn.getClear());
                     }
                     else
-Original file line number
+Diff line change
@@ Expand Up @@
                                     WARNLOG("Invalid col type found in logaccess logmap config");
                                 }
                             }
+                            else
+                            {
+                                espLogColumn->setColumnType("string");
+                            }
                             logColumns.append(*espLogColumn.getClear());
                         }
                         else
@@ Expand Down @@