This repository has been archived by the owner on Apr 24, 2018. It is now read-only.

Fix Python 3 issue, use str instead of basestring #3

Open

michael-erasmus wants to merge 1 commit into kennethreitz-archive:master from michael-erasmus:master

michael-erasmus commented Nov 13, 2017

Hey @kennethreitz!

Just a small PR to fix an issue I got trying to use this with Python3.

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "/opt/conda/lib/python3.5/site-packages/dynamo.py", line 48, in __setitem__
    if isinstance(key, (basestring, Number)):
NameError: name 'basestring' is not defined

This was pretty easy to fix, just forked the repo and ran:

2to3 -wn dynamo.py


          Fix Python 3 issue, use str instead of basestring

71c6c2e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet