feat: throw instead of silently rewriting invalid cron expressions #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing an illegal cron string will now throw upon initialization
sheerlox
changed the title
|
ping @intcreator |
intcreator
approved these changes
Jan 10, 2025
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
intcreator
pushed a commit
that referenced
this pull request
Jan 10, 2025
## [3.5.0](v3.4.0...v3.5.0) (2025-01-10) ### ✨ Features * throw instead of silently rewriting invalid cron expressions ([#937](#937)) ([dcc5b93](dcc5b93)) ### ⚙️ Continuous Integrations * **action:** update step-security/harden-runner action to v2.10.3 ([#943](#943)) ([cd7ee9f](cd7ee9f)) ### ♻️ Chores * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.12 ([2a867f9](2a867f9)) * **deps:** update dependency [@types](https://github.com/types)/node to v22 ([#900](#900)) ([f7548bd](f7548bd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes an outdated function that would silently rewrite invalid expressions, e.g.
0 0 30 FEB *to0 0 1 FEB *.Related Issues
N/A
Motivation and Context
@Anurag-Bansal1 stumbled upon the
MONTH_CONSTRAINTSconstant while exploring the codebase and asked why29was chosen for February.This constant is only used by the
_verifyParsefunction, and upon careful review, it looks like this function was added a very long time ago to prevent infinite loops, which is a problem that we've since resolved at a deeper level.How Has This Been Tested?
Added a new test case. See the failed test in CI before I pushed the code changes.
Screenshots (if appropriate):
Initially discussed on Discord:
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).Related Commits
From most to least recent: