Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: optimise ed25519 #298

Merged
merged 3 commits into from
May 15, 2024
Merged

enh: optimise ed25519 #298

merged 3 commits into from
May 15, 2024

Conversation

edisontim
Copy link
Contributor

@edisontim edisontim commented Apr 25, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • 15% less gas usage via various changes in the ed25519 verification algo

Does this introduce a breaking change?

  • Yes
  • No

Other information

@edisontim edisontim requested a review from 0xLucqs as a code owner April 25, 2024 18:17
@0xLucqs 0xLucqs merged commit 1b6091d into keep-starknet-strange:main May 15, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edisontim @0xLucqs