-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix invalid signature verification #289
fix: fix invalid signature verification #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue what's happening here, can you add some context plz
The format I was using before for the signature as well as for the public key was very inconvenient. |
otherwise looks good |
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Adapted the format of the signature to something more representative and fixed an issue with signatures not being verified correctly. Added some test cases that were generated by the javascript lib Noble
Does this introduce a breaking change?
Other information