Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Little endian support for ByteArray extensions #195

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: Little endian support for ByteArray extensions #195

merged 1 commit into from
Oct 20, 2023

Conversation

sveamarcus
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Currently supports encoding and decoding from big endian ByteArray, which remains the default behaviour.

What is the new behavior?

  • Adds support for little endian encoding when storing or reading a ByteArray

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sveamarcus sveamarcus requested a review from 0xLucqs as a code owner October 17, 2023 18:25
@sveamarcus
Copy link
Contributor Author

There is an update coming to ByteArrayReader as well. Then, there is a pending addition of SipHash optimized for cairo/validity proofs, which depends on these little endian additions.

@0xLucqs 0xLucqs merged commit 0c01185 into keep-starknet-strange:main Oct 20, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants