Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ReversibleBytes and ReversibleBits traits that add support for byte and bit reversal #192

Merged
merged 12 commits into from
Oct 17, 2023

Conversation

sveamarcus
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Adds byte endianness reversal as well as bit reversal of unsigned types
  • Also applies to arrays of reversible elements
  • Supports bytes31 tightly packed byte or bit arrays
  • Avoids any bit-wise operations

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sveamarcus sveamarcus requested a review from 0xLucqs as a code owner October 13, 2023 11:48
@0xLucqs 0xLucqs merged commit 713144f into keep-starknet-strange:main Oct 17, 2023
3 checks passed
@0xLucqs
Copy link
Collaborator

0xLucqs commented Oct 17, 2023

hey @sveamarcus can you register on https://app.onlydust.xyz/ so i can pay for your contribution ? (can you also tell me how many hours/days you spent on this pr plz)

@sveamarcus
Copy link
Contributor Author

That would be greatly appreciated, thank you. I did register a profile. If you are hiring let me know 😄

It's hard to say, I have been going 40 hour weeks for four weeks now but this specific change may have required a couple of work days including refinement and testing.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants