Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keccak256 #179

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: keccak256 #179

merged 3 commits into from
Sep 20, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 20, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Implements keccak256 from a bytes input.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@enitrat enitrat requested a review from 0xLucqs as a code owner September 20, 2023 04:33
src/math/src/keccak256.cairo Outdated Show resolved Hide resolved
src/math/src/keccak256.cairo Show resolved Hide resolved
src/math/src/keccak256.cairo Outdated Show resolved Hide resolved
src/math/src/tests/test_keccak256.cairo Outdated Show resolved Hide resolved
@enitrat
Copy link
Collaborator Author

enitrat commented Sep 20, 2023

Applied suggestions, added size <=8 assertion

@0xLucqs 0xLucqs merged commit 46c8d8a into keep-starknet-strange:main Sep 20, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants