Public zeroable on i257 (#300)

Make public Zeroable on i257 and fix is_zero for negative numbers
keep-starknet-strange · May 10, 2024 · c9995a4 · c9995a4
1 parent 22349af
commit c9995a4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/math/src/i257.cairo b/src/math/src/i257.cairo
@@ -266,13 +266,17 @@ impl i257Neg of Neg<i257> {
     }
 }
 
-impl i257Zeroable of Zero<i257> {
+pub impl i257Zeroable of Zero<i257> {
     fn zero() -> i257 {
         I257Impl::new(0, false)
     }
     fn is_zero(self: @i257) -> bool {
-        assert(!*self.is_negative, 'no negative zero');
-        *self.abs == 0
+        if *self.abs == 0 {
+            assert(!*self.is_negative, 'no negative zero');
+            true
+        } else {
+            false
+        }
     }
     fn is_non_zero(self: @i257) -> bool {
         !self.is_zero()