Address PR comments

keep-starknet-strange · Apr 3, 2024 · ac98f8e · ac98f8e
1 parent 39168f8
commit ac98f8e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/math/src/ed25519.cairo b/src/math/src/ed25519.cairo
@@ -90,7 +90,7 @@ impl PartialEqExtendedHomogeneousPoint of PartialEq<ExtendedHomogeneousPoint> {
 }
 
 impl SpanU8IntoU256 of Into<Span<u8>, u256> {
-    // Decode as little endian
+    /// Decode as little endian
     fn into(self: Span<u8>) -> u256 {
         if (self.len() > 32) {
             return 0;
@@ -187,10 +187,9 @@ impl U256TryIntoPoint of TryInto<u256, Point> {
         let mut y_le_span: Span<u8> = y_span.reverse().span();
 
         let last_byte = *y_le_span[31];
-        let mut normed = y_le_span.clone();
 
-        let _ = normed.pop_back();
-        let mut normed_array: Array<u8> = normed.dedup();
+        let _ = y_le_span.pop_back();
+        let mut normed_array: Array<u8> = y_le_span.dedup();
         normed_array.append(last_byte & ~0x80);
 
         let x_0: u256 = (last_byte.into() / 128) & 1; // bitshift of 255

diff --git a/src/math/src/tests/ed25519_test.cairo b/src/math/src/tests/ed25519_test.cairo
@@ -69,5 +69,5 @@ fn verify_signature_invalid() {
     let s_sign: u256 = 0x68e015fa8775659d1f40a01e1f69b8af4409046f4dc8ff02cdb04fdc3585eb01;
     let signature = array![r_sign, s_sign];
 
-    assert!(verify_signature(msg, signature.span(), pub_key) == false, "Invalid signature");
+    assert!(!verify_signature(msg, signature.span(), pub_key), "Invalid signature");
 }