Tb91

[antixn]

Needed changes for Keebird migration to Thunderbird 91

[dlech]

Thanks for the work on this. I don't use keebird anymore and I already maintain too many other open source projects. So I'll leave it up to @luckyrat if he wants to review this or invite a new maintainer for this project. If that doesn't happen, then you can always fork the project and publish your own version of the extension.

[ikenichiro]

Thanks for checking in and leaving a comment for future direction dlech.
Since some e-mail providers still does not have OAuth2 (and some require you to change your password twice a year ish), this addon has been necessary for me a long time,
Thank you for all the past work you've done for this project.

[ikenichiro]

I was able to reproduce @Janpopan situation, and I still see after updating to 102.3.0 too.
(I'm using this thread since I think it should be discussed here rather than #33 ).

I'm not sure how I got able to reproduce, but delete/add still seems to reproduce, and now I can't get it back it working ;(
In the Error Console I see

redeclaration of const Services [KFcommonDialog.js:1](chrome://keefox/content/KFcommonDialog.js)
    <anonymous> chrome://keefox/content/KFcommonDialog.js:1
    <anonymous> chrome://keefox/content/scripts/KFcommonDialog.js:5
    _loadIntoWindow jar:file:///D:/Thunderbird/extensions/[email protected]!/api/windowListener/implementation.js:908
    onLoadWindow jar:file:///D:/Thunderbird/extensions/[email protected]!/api/windowListener/implementation.js:740
    checkAndRunExtensionCode resource:///modules/ExtensionSupport.jsm:220
    _checkAndRunMatchingExtensions resource:///modules/ExtensionSupport.jsm:195
    _addToListAndNotify resource:///modules/ExtensionSupport.jsm:179
    _waitForLoad resource:///modules/ExtensionSupport.jsm:156
    nsIPrompt_promptPassword resource:///modules/MsgAsyncPrompter.jsm:621
    promptPassword resource:///modules/MsgAsyncPrompter.jsm:389
    _promiseAuthPrompt resource:///modules/MsgAsyncPrompter.jsm:54
    _promiseAuthPrompt resource:///modules/MsgAsyncPrompter.jsm:52
    run resource:///modules/MsgAsyncPrompter.jsm:77
    InterpretGeneratorResume self-hosted:1422
    AsyncFunctionNext self-hosted:632

any ideas for fix? @antixn

[Janpopan]

There are more than on problem.
I was able to solve one - the html namespace was not registerd.
Modify siteOptions.xhtml in this way:

<dialog id="KeeFoxSiteOptions" title="" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" buttons="extra1" buttonlabelextra1="Close" onload="onLoad();" xmlns:html="http://www.w3.org/1999/xhtml">

[Janpopan]

Next things
No chrome package registered for chrome://keefox/skin/options.css

No chrome package registered for chrome://keefox/skin/keefox.css

[Janpopan]

redeclaration of cont KeeFoxLog

[luckyrat]

I have too many other commitments at the moment to take on KeeBird and it's been far too many years since I worked with XUL extensions for me to be confident that I could adequately review any code changes now. If you can all reach a consensus on who should replace @dlech as maintainer then I'm happy to offer the relevant privileges on this repo. @dlech would then need to handle the handover of whatever permissions are needed for the extension distribution platform though (used to be addons.mozilla.org but I'm not sure if that's changed over the years).

[antixn]

I was able to reproduce @Janpopan situation, and I still see after updating to 102.3.0 too. (I'm using this thread since I think it should be discussed here rather than #33 ).

I'm not sure how I got able to reproduce, but delete/add still seems to reproduce, and now I can't get it back it working ;( In the Error Console I see

redeclaration of const Services [KFcommonDialog.js:1](chrome://keefox/content/KFcommonDialog.js)
    <anonymous> chrome://keefox/content/KFcommonDialog.js:1
    <anonymous> chrome://keefox/content/scripts/KFcommonDialog.js:5
    _loadIntoWindow jar:file:///D:/Thunderbird/extensions/[email protected]!/api/windowListener/implementation.js:908
    onLoadWindow jar:file:///D:/Thunderbird/extensions/[email protected]!/api/windowListener/implementation.js:740
    checkAndRunExtensionCode resource:///modules/ExtensionSupport.jsm:220
    _checkAndRunMatchingExtensions resource:///modules/ExtensionSupport.jsm:195
    _addToListAndNotify resource:///modules/ExtensionSupport.jsm:179
    _waitForLoad resource:///modules/ExtensionSupport.jsm:156
    nsIPrompt_promptPassword resource:///modules/MsgAsyncPrompter.jsm:621
    promptPassword resource:///modules/MsgAsyncPrompter.jsm:389
    _promiseAuthPrompt resource:///modules/MsgAsyncPrompter.jsm:54
    _promiseAuthPrompt resource:///modules/MsgAsyncPrompter.jsm:52
    run resource:///modules/MsgAsyncPrompter.jsm:77
    InterpretGeneratorResume self-hosted:1422
    AsyncFunctionNext self-hosted:632

any ideas for fix? @antixn

When i started to work on the plugin it was already unable to reload properly from thunderbird. It is an issue for sure but i did not work on it. I have spotted another one with TB102 and pushed a new PR, maybe it will help.

To output more logs you can uncomment lines 273 & 274 from xul-ext/modules/KFLogger.js

It could help understand what's failing.

Thanks for your answers @dlech & @luckyrat. I am a bit afraid to say it too loudly but it looks like i want to take some responsability in this project. Once we will have a running version for the users of this thread it would make sense to publish it.

[antixn]

@Janpopan the namespace fix is pushed on the next PR