Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI to matched entry card for configuring match preference #275

Closed
luckyrat opened this issue Oct 7, 2020 · 1 comment
Closed

Add UI to matched entry card for configuring match preference #275

luckyrat opened this issue Oct 7, 2020 · 1 comment
Assignees
Milestone

Comments

@luckyrat
Copy link
Member

luckyrat commented Oct 7, 2020

  • Allow matched entries to render differently to non-matched entries - perhaps implicitly via a true/false/undefined flag to indicate if the entry is the current preferred match.
  • Add a new row underneath current card contents with a star icon button and label: “Preferred matching entry”
  • Tooltip upon hovering over the star icon button: “Make this my preferred entry for this website”
  • Clicking the button will behave as described below.

if this entry is the current preferred entry:
1. remove all config settings that can make it the current preferred entry (all Domain, hostname and page settings that specify this entry’s UUID)

else:
1. if another entry is the current preferred entry remove all config settings that can determine the current preferred entry if they are equally or more specific than the configured target
2. create a new “Exact method” per-site setting to record the UUID of the entry using the configured target

* if #276 has not been implemented: configured target = Domain

When removing an existing setting, we’ll either remove just the preferred entry UUID or, if we can determine that no non-default options are in use for the specific site configuration, we can remove the entire per-site configuration for the target and value in question.

@luckyrat luckyrat self-assigned this Oct 7, 2020
luckyrat added a commit that referenced this issue Oct 17, 2020
Adds jest for some targetted automated testing.
Business logic is not yet connected to any sort of UI.
Refs #275
@luckyrat
Copy link
Member Author

I'll use a checkbox rather than a star icon since this is more likely to be understood by a larger number of users. Additionally, I think that the checkbox along with the label next to it should provide enough information that the additional noise from a tooltip is unnecessary so I'll skip that part of the design.

luckyrat added a commit that referenced this issue Oct 20, 2020
luckyrat added a commit that referenced this issue Oct 20, 2020
Adds jest for some targetted automated testing.
Business logic is not yet connected to any sort of UI.
Refs #275
@luckyrat luckyrat added this to the 3.6 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant