Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preferred entry for auto-fill/submit even if it is not the best match #277

Closed
luckyrat opened this issue Oct 7, 2020 · 0 comments
Closed

Use preferred entry for auto-fill/submit even if it is not the best match #277

luckyrat opened this issue Oct 7, 2020 · 0 comments
Assignees
@luckyrat
Labels
enhancement
Milestone
3.6

Comments

@luckyrat
Copy link
Member

luckyrat commented Oct 7, 2020

We should already have access to the relevant config in formFilling.ts once #275 is complete so the changes should be fairly simple:

  • This only overrides automatic form filling/submitting; manual submission is unaffected
  • All the usual decisions regarding entry behaviour are observed. E.g.
    • marking an entry as preferred will not change that entry’s auto-fill/submit behaviour
    • preferred entries that are a very poor match for the form will not be auto-filled
@luckyrat luckyrat self-assigned this Oct 17, 2020
luckyrat added a commit that referenced this issue Oct 20, 2020
@luckyrat
Use preferred entry for auto-fill/submit even if not best match
14e3fc0 
Fixes #277
@luckyrat luckyrat added this to the 3.6 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luckyrat luckyrat

Labels
enhancement
Projects
None yet
Milestone
3.6
Development

No branches or pull requests
1 participant
@luckyrat