Adding code to run on Powersystem #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedder
reviewed
Dec 4, 2020
.travis.yml
Outdated
| before_install: | ||
| - curl -sSL https://raw.githubusercontent.com/sdispater/poetry/master/get-poetry.py > get-poetry.py | ||
| - python get-poetry.py -y --version 1.0.0b3 | ||
| - source ~/.poetry/env |
There was a problem hiding this comment.
Hm, I wouldn't like to depend on poetry. Is it needed to support additional architectures?
kedder
reviewed
Dec 4, 2020
| - arch: ppc64le | ||
| python: 3.6 | ||
| - arch: ppc64le | ||
| python: 3.7 |
There was a problem hiding this comment.
Can you also add some comments here why these are excluded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Here is my contribution to your code, its working good on powersystems.
Thanks for the code, its working good.
What do these changes do?
Added Architecture "ppc64le"
Are there changes in behavior for the user?
No