Update sample to dotnet 8, use simplified API, simplify authentication

.gitignore

@@ -8,7 +8,7 @@
 *.user
 *.userosscache
 *.sln.docstates
-
+*/**/appsettings.local.json
 # User-specific files (MonoDevelop/Xamarin Studio)
 *.userprefs
 
@@ -221,7 +221,7 @@ ClientBin/
 *.publishsettings
 orleans.codegen.cs
 
-# Including strong name files can present a security risk 
+# Including strong name files can present a security risk
 # (https://github.com/github/gitignore/pull/2483#issue-259490424)
 #*.snk
 
@@ -317,7 +317,7 @@ __pycache__/
 # OpenCover UI analysis results
 OpenCover/
 
-# Azure Stream Analytics local run output 
+# Azure Stream Analytics local run output
 ASALocalRun/
 
 # MSBuild Binary and Structured Log
@@ -326,6 +326,6 @@ ASALocalRun/
 # NVidia Nsight GPU debugger configuration file
 *.nvuser
 
-# MFractors (Xamarin productivity tool) working folder 
+# MFractors (Xamarin productivity tool) working folder
 .mfractor/
-/src/docker-compose.override.yml
+/src/docker-compose.override.yml

deploy/connection-string/deploy-app.yaml

@@ -17,14 +17,14 @@ spec:
       - name: order-processor
         image: ghcr.io/kedacore/sample-dotnet-worker-servicebus-queue:latest
         env:
-        - name: KEDA_SERVICEBUS_AUTH_MODE
+        - name: OrderQueueOptions__AuthMode
           value: ConnectionString
-        - name: KEDA_SERVICEBUS_QUEUE_CONNECTIONSTRING
+        - name: OrderQueueOptions__ConnectionString
           valueFrom:
             secretKeyRef:
              name: secrets-order-consumer
              key: servicebus-connectionstring
-        - name: KEDA_SERVICEBUS_QUEUE_NAME
+        - name: OrderQueueOptions__QueueName
           value: orders
 ---
 apiVersion: v1
@@ -34,4 +34,4 @@ metadata:
   labels:
     app: order-processor
 data:
-  servicebus-connectionstring: <base64-encoded-connection-string>
+  servicebus-connectionstring: <base64-encoded-connection-string>

deploy/deploy-web.yaml

@@ -17,18 +17,23 @@ spec:
       - name: order-web
         image: ghcr.io/kedacore/sample-dotnet-worker-servicebus-portal
         env:
-        - name: KEDA_SERVICEBUS_QUEUE_CONNECTIONSTRING
+          - name: OrderQueueOptions__AuthMode
+            value: ConnectionString
+        env:
+        - name: OrderQueueOptions__ConnectionString
           valueFrom:
             secretKeyRef:
              name: secrets-order-portal
              key: servicebus-connectionstring
+        - name: OrderQueueOptions__QueueName
+          value: orders
 ---
 apiVersion: v1
 kind: Service
 metadata:
   name: kedasampleweb
   labels:
-    app: order-web  
+    app: order-web
   annotations:
     # Expose service on <label-name>.<location>.cloudapp.azure.com
     service.beta.kubernetes.io/azure-dns-label-name: keda-orders-portal

deploy/pod-identity/deploy-app-with-pod-identity.yaml

@@ -37,11 +37,11 @@ spec:
       - name: order-processor
         image: ghcr.io/kedacore/sample-dotnet-worker-servicebus-queue:latest
         env:
-        - name: KEDA_SERVICEBUS_AUTH_MODE
+        - name: OrderQueueOptions__AuthMode
           value: PodIdentity
-        - name: KEDA_SERVICEBUS_HOST_NAME
+        - name: OrderQueueOptions__FullyQualifiedNamespace
           value: <namespace-name>.servicebus.windows.net
-        - name: KEDA_SERVICEBUS_QUEUE_NAME
+        - name: OrderQueueOptions__QueueName
           value: orders
-        - name: KEDA_SERVICEBUS_IDENTITY_USERASSIGNEDID
-          value: <app-identity-id>
+        - name: OrderQueueOptions__ClientId
+          value: <app-identity-id>

deploy/workload-identity/deploy-app-with-workload-identity.yaml

@@ -28,9 +28,9 @@ spec:
       - name: order-processor
         image: ghcr.io/kedacore/sample-dotnet-worker-servicebus-queue:latest
         env:
-        - name: KEDA_SERVICEBUS_AUTH_MODE
+        - name: OrderQueueOptions__AuthMode
           value: WorkloadIdentity
-        - name: KEDA_SERVICEBUS_HOST_NAME
+        - name: OrderQueueOptions__FullyQualifiedNamespace
           value: <namespace-name>.servicebus.windows.net
-        - name: KEDA_SERVICEBUS_QUEUE_NAME
+        - name: OrderQueueOptions__QueueName
           value: orders

pod-identity.md

@@ -339,7 +339,7 @@ To build and run the web app locally, add the service bus connection string to a
 There is also a docker image available, so you can also run it locally with the following command:
 
 ```cli
-docker run -p 8080:80 -d -e OrderQueue__ConnectionString="KEDA_SERVICEBUS_QUEUE_CONNECTIONSTRING" kedasamples/sample-dotnet-web 
+docker run -p 8080:80 -d -e OrderQueue__ConnectionString="<connection-string>" kedasamples/sample-dotnet-web 
 ```
 
 To deploy the web application to your Kubernetes cluster:

src/Keda.Samples.DotNet.Web/Dockerfile

@@ -1,9 +1,9 @@
-FROM mcr.microsoft.com/dotnet/core/aspnet:3.1.1-alpine AS base
+FROM mcr.microsoft.com/dotnet/runtime:8.0 AS base
 WORKDIR /app
 EXPOSE 80
 EXPOSE 443
 
-FROM mcr.microsoft.com/dotnet/core/sdk:3.1.101-alpine AS build
+FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build
 WORKDIR /src
 COPY ["Keda.Samples.DotNet.Web/Keda.Samples.DotNet.Web.csproj", "Keda.Samples.DotNet.Web/"]
 COPY ["Keda.Samples.Dotnet.Contracts/Keda.Samples.Dotnet.Contracts.csproj", "Keda.Samples.Dotnet.Contracts/"]

src/Keda.Samples.DotNet.Web/Keda.Samples.DotNet.Web.csproj

@@ -1,28 +1,22 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
+    <LangVersion>12</LangVersion>
     <DockerComposeProjectPath>..\docker-compose.dcproj</DockerComposeProjectPath>
     <UserSecretsId>858adc6c-c378-4698-a3c4-1112a29d6561</UserSecretsId>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <DocumentationFile>Keda.Samples.DotNet.Web.Open-Api.xml</DocumentationFile>
     <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Guard.Net" Version="1.2.0" />
-    <PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="2.1.0" />
-    <PackageReference Include="Microsoft.Azure.ServiceBus" Version="5.0.0" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="3.1.1" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="3.1.1">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-    <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="3.1.1" />
-    <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.9.10" />
-    <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="3.1.0" />
-    <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="5.0.0" />
-    <PackageReference Include="Swashbuckle.AspNetCore.SwaggerUI" Version="5.0.0" />
+    <PackageReference Include="Guard.Net" Version="3.0.0" />
+    <PackageReference Include="Azure.Messaging.ServiceBus" Version="7.17.5" />
+    <PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="5.0.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="6.6.2" />
+    <PackageReference Include="Swashbuckle.AspNetCore.SwaggerUI" Version="6.6.2" />
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Keda.Samples.DotNet.Web/Pages/Error.cshtml

@@ -1,19 +1,11 @@
 @page
-@model ErrorModel
 @{
     ViewData["Title"] = "Error";
 }
 
 <h1 class="text-danger">Error.</h1>
 <h2 class="text-danger">An error occurred while processing your request.</h2>
 
-@if (Model.ShowRequestId)
-{
-    <p>
-        <strong>Request ID:</strong> <code>@Model.RequestId</code>
-    </p>
-}
-
 <h3>Development Mode</h3>
 <p>
     Swapping to the <strong>Development</strong> environment displays detailed information about the error that occurred.

src/Keda.Samples.DotNet.Web/Pages/Privacy.cshtml

@@ -1,5 +1,4 @@
 @page
-@model PrivacyModel
 @{
     ViewData["Title"] = "Privacy Policy";
 }