Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use kedacore cached trivy image #6243

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 16, 2024

https://github.com/orgs/kedacore/packages/container/package/trivy-db

for now, synced manually by:

$ oras cp ghcr.io/aquasecurity/trivy-db:2 ghcr.io/kedacore/trivy-db:2

I will followup with some automation later

@wozniakjan wozniakjan requested a review from a team as a code owner October 16, 2024 08:10
@wozniakjan
Copy link
Member Author

/skip-e2e

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work 😄
The value that you have replaced is the image to be tested, not the image used.
We must set the env 'TRIVY_DB_REPOSITORY' in the task, pointing to the image -> https://aquasecurity.github.io/trivy/v0.27.1/docs/references/cli/server/

--db-repository value            OCI repository to retrieve trivy-db from (default: "ghcr.io/aquasecurity/trivy-db") [$TRIVY_DB_REPOSITORY]

@wozniakjan
Copy link
Member Author

We must set the env 'TRIVY_DB_REPOSITORY' in the task, pointing

oh, my bad, will setting env on the workflow_call be sufficient or should I rather make it configurable input to the workflow_call?

@JorTurFer JorTurFer merged commit a9a7702 into kedacore:main Oct 16, 2024
20 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants