Aws secretsmanager additions #6031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
tests/secret-providers/aws_secretmanager_pod_identity/aws_secretmanager_pod_identity_test.go
Outdated
Show resolved
Hide resolved
tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
| secrets: | ||
| - parameter: connection | ||
| name: {{.SecretManagerSecretName}} | ||
| secretKey: connectionString |
There was a problem hiding this comment.
This indentation does not show up on my machine. Not sure why it is here
There was a problem hiding this comment.
it produces e2e failures :( Could you fix it? Maybe you need to make 2 commits as usually tabs and whitespace are ignored depending on config
|
/run-e2e secret-providers |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed due to inactivity. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify a
secretKeyin theawsSecretManagerTriggerAuthentication. This will allow parsing of secrets that contain Key/Value pairs (returned in JSON format).Checklist
Fixes #
#5940
Relates to #