Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CloudEvents content reflects correct emitter namespace and subject type #5279

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: CloudEvents content reflects correct emitter namespace and subject type #5279

merged 2 commits into from
Dec 12, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5278

@JorTurFer JorTurFer requested a review from a team as a code owner December 11, 2023 23:16
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 11, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer changed the title fix: Update CloudEvent content to reflect correct emitter and subject fix: Update CloudEvent content to reflect correct emitter namespace and subject type Dec 11, 2023
@JorTurFer JorTurFer changed the title fix: Update CloudEvent content to reflect correct emitter namespace and subject type fix: CloudEvent content reflects correct emitter namespace and subject type Dec 11, 2023
@JorTurFer JorTurFer changed the title fix: CloudEvent content reflects correct emitter namespace and subject type fix: CloudEvents content reflects correct emitter namespace and subject type Dec 11, 2023
tomkerkhove
tomkerkhove approved these changes Dec 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Apply feedback
1b26803 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

/skip-e2e

@JorTurFer JorTurFer enabled auto-merge (squash) December 12, 2023 08:16
@JorTurFer JorTurFer merged commit a2c21ec into kedacore:main Dec 12, 2023
20 checks passed
@JorTurFer JorTurFer deleted the update-cloud-events branch December 12, 2023 08:16
@JorTurFer
Copy link
Member Author

/skip-e2e

@tomkerkhove . I skipped e2e test because the latest commit only updated the changelog and previous commits passed them, passing them again didn't make sense just for a change in changelog xD

toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@JorTurFer @toniiiik
fix: CloudEvents content reflects correct emitter namespace and subje…
8dfde4b 
…ct type (kedacore#5279)

Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudEvents content doesn't reflect correct emitter namespace and subject type
3 participants
@JorTurFer @tomkerkhove @keda-automation