Skip to content

Commit

Permalink
Fix GitHub actions
Browse files Browse the repository at this point in the history
* Update golangci version to 1.60 for golang 1.23 (or it will consume
  all memory and eventually be killed by the runner and exit with error
  code 143)
* Update pre-commit to new version and migrate hook names to new names

Signed-off-by: Joel Smith <[email protected]>
  • Loading branch information
joelsmith committed Nov 8, 2024
1 parent c033042 commit 87734df
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pr-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ jobs:
with:
go-version: '1.22'
- name: Get golangci
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.56.2
- uses: pre-commit/[email protected].0
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.1
- uses: pre-commit/[email protected].1

test-build:
name: Test Image Build
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
default_stages: [commit, push]
default_stages: [pre-commit, pre-push]
minimum_pre_commit_version: "1.20.0"
repos:
- repo: https://github.com/dnephin/pre-commit-golang
Expand All @@ -7,7 +7,7 @@ repos:
- id: go-fmt
name: Run go fmt against the code
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v3.4.0
rev: v5.0.0
hooks:
- id: trailing-whitespace
- id: detect-private-key
Expand Down

0 comments on commit 87734df

Please sign in to comment.