Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link for coolDownPeriod #1491

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix link for coolDownPeriod #1491

merged 1 commit into from
Oct 25, 2024

Conversation

rickbrouwer
Copy link
Contributor

Fix inaccessible links at the cooldownPeriod info

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@rickbrouwer
Fix link for coolDownPeriod
bf90999 
Signed-off-by: Rick Brouwer <[email protected]>
@rickbrouwer rickbrouwer requested a review from a team as a code owner October 25, 2024 12:36
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit bf90999
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/671b90c1772fac000971ef50
😎 Deploy Preview https://deploy-preview-1491--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zroubalik
zroubalik approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit fa238ce into kedacore:main Oct 25, 2024
8 checks passed
@rickbrouwer rickbrouwer deleted the cooldown branch October 26, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickbrouwer @zroubalik