-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Procedure for Setting Up Autoscaling with KEDA #1446
Conversation
Signed-off-by: shubhusion <[email protected]>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Hi @zroubalik ,@JorTurFer, Could you please review the finalized PR for #1368? The changes you specified in the previous PR #1415 have been implemented here. However, due to an issue with rebasing, I had to close the earlier PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The only point is that we should include it also as part of v2.16 (if you rebase the branch the folder will be there).
There is another question that comes to my mind, maybe we could transform this into a getting started that we place in the getting started section instead of a versioned documentation. WDYT @tomkerkhove @zroubalik ?
Maybe we can do it in a following PR just refactoring a bit this one (which is nice, tbh)
Signed-off-by: shubhusion <[email protected]>
@JorTurFer Included in v2.16 also and file is present in Getting Started Section for v2.15 and v2.16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JorTurFer agree on the Getting Started Guide, I think this is something we can do as a follow up.
Description of Changes
Created a procedure for setting up a scaler in KEDA.
Checklist
Issue Fixed
Fixes kedacore/keda-docs#1368