Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate fallback configuration #1356

Merged
merged 1 commit into from
Apr 24, 2024
Merged

feat: validate fallback configuration #1356

merged 1 commit into from
Apr 24, 2024

Conversation

guopeng0
Copy link
Contributor

@guopeng0 guopeng0 commented Apr 9, 2024 •
edited
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1355

@guopeng0 guopeng0 requested a review from a team as a code owner April 9, 2024 12:14
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 2d0a325
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/661531234f99390008cc8b45
😎 Deploy Preview https://deploy-preview-1356--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove tomkerkhove merged commit 546775c into kedacore:main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update docs for validate fallback configuration
3 participants
@guopeng0 @zroubalik @tomkerkhove