Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add linux node selector to deployments #545

Closed
wants to merge 1 commit into from

Conversation

pzerelles
Copy link

When KEDA is deployed to a mixed Kubernetes cluster with linux and windows nodes, the deployments did not select the linux nodes explicitly and could not be started on windows nodes.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [-] README is updated with new configuration values (if applicable) learn more
  • [-] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

@pzerelles pzerelles requested a review from a team as a code owner October 5, 2023 12:50
@JorTurFer
Copy link
Member

JorTurFer commented Oct 5, 2023

We are cutting a release of the HTTP add-on right now, so I have just included the missing node selector within it
#543

@pzerelles
Copy link
Author

pzerelles commented Oct 5, 2023 via email

@JorTurFer
Copy link
Member

I close this as I have included your changes in that PR in progress (it's faster than fix your PR, merge it and update the other). Thanks for the PR in any case

@JorTurFer JorTurFer closed this Oct 5, 2023
@JorTurFer JorTurFer mentioned this pull request Oct 5, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants