Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tlsConfig for ServiceMonitor #539

Closed
wants to merge 24 commits into from
Closed

Add tlsConfig for ServiceMonitor #539

wants to merge 24 commits into from

Conversation

guicholeo
Copy link
Contributor

@guicholeo guicholeo commented Sep 28, 2023 •
edited
Loading

Add configuration for tlsConfig

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

@guicholeo guicholeo requested a review from a team as a code owner September 28, 2023 21:16
JorTurFer
JorTurFer reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your PR and execute helm-docs?

keda/Chart.yaml Outdated
version: 2.12.0

version: 2.12.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change, we bump the version during releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

@guicholeo guicholeo force-pushed the add-tls-templating branch 2 times, most recently from 274185b to 2c14d2a Compare November 13, 2023 15:35
@guicholeo guicholeo requested a review from JorTurFer November 13, 2023 15:35
@guicholeo guicholeo changed the title Improve port naming and add tlsConfig for ServiceMonitor Add tlsConfig for ServiceMonitor Jan 12, 2024
@guicholeo guicholeo force-pushed the add-tls-templating branch 2 times, most recently from 666d6c0 to 41f28b3 Compare January 16, 2024 17:16
JorTurFer
JorTurFer approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contruibution!

guicholeo and others added 18 commits January 18, 2024 20:50
@guicholeo @JorTurFer
Added prometheus port name
99fc202 
Signed-off-by: guicholeo <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@guicholeo @JorTurFer
Rebase
6b0530b 
Signed-off-by: guicholeo <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@QuentinBisson @JorTurFer
Allow image registry override for all keda components (kedacore#557)
6443b5c 
Signed-off-by: Jorge Turrado <[email protected]>
@tomkerkhove @JorTurFer
docs: Clarify that contributors do not have to ship Helm chart (kedac…
7fd1a56 
…ore#573)

Signed-off-by: Jorge Turrado <[email protected]>
@Adarsh-verma-14 @JorTurFer
add disable-compression arg for both operator and metrics-server (ked…
ad3785a 
…acore#554)

Signed-off-by: Adarsh-verma-14 <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@SpiritZhou @tomkerkhove @JorTurFer
feat: Introduce CloudEventSources CRD and adding ClusterName parameter (
93c5975 
kedacore#572)

* Add CloudEventSources Crd and ClustetName Parameter

Signed-off-by: SpiritZhou <[email protected]>

* Update

Signed-off-by: SpiritZhou <[email protected]>

* Update

Signed-off-by: SpiritZhou <[email protected]>

* Update keda/values.yaml

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>

* Fix

Signed-off-by: SpiritZhou <[email protected]>

* Update

Signed-off-by: SpiritZhou <[email protected]>

* Revert unnecessary update

Signed-off-by: SpiritZhou <[email protected]>

---------

Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@zroubalik @JorTurFer
store 2.12.1 package at main (kedacore#577)
9bd385b 
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix: restore http-add-on chart 0.6.0 indexing (kedacore#579)
eca6397 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix(add-on): Use 'main' tag for KEDA installation during CI (kedacore…
1ff4af4 
…#582)

Signed-off-by: Jorge Turrado <[email protected]>
@eumel8 @tomkerkhove @JorTurFer
set securityContext for http-add-on chart (kedacore#561)
d5468e7 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@aballman @JorTurFer
Fix http-add-on operator resources (kedacore#567)
ccd2e50 
Signed-off-by: Jorge Turrado <[email protected]>
@aballman @JorTurFer
Fix http-add-on verbosity configuration (kedacore#568)
71c7583 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
chore: Adjust RBAC with code (kedacore#585)
73dbd6f 
* chore: Adjust RBAC with code

Signed-off-by: Jorge Turrado <[email protected]>

* fix typo

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix: Don't recreate CA with 8 months until it expires (kedacore#586)
b7ad8bb 
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@guicholeo @JorTurFer
Removed port/portname changes
b7ad90a 
Signed-off-by: Jorge Turrado <[email protected]>
@guicholeo @JorTurFer
Update Helm Docs
63b9d34 
Signed-off-by: guicholeo <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@Bhargav-InfraCloud @JorTurFer
feat(ClusterRole): Add RBAC rule to allow access to LimitRange (ked…
94aae69 
…acore#588)

Signed-off-by: Jorge Turrado <[email protected]>
@eumel8 @JorTurFer
remove not required insecureSkipTLSVerify (kedacore#564)
1e0a782 
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
ferndem and others added 6 commits January 18, 2024 20:50
@ferndem @JorTurFer
Update templates/webhooks deployment (kedacore#590)
f9098dd 
Align deployment for extraVolumes and extraVolumesMount for fix problem Error: YAML parse error on keda/templates/webhooks/deployment.yaml: error converting YAML to JSON: yaml: line 96: did not find expected key

Signed-off-by: ferndem <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@mplzik @JorTurFer
Fix Prometheus metrics handling for the operator. (kedacore#555)
8c080b2 
The current state of the Helm chart is slightly confusing, because:
- There's no easy way to really disable prometheus metrics --
  `--enable-prometheus-metrics` defaults to true anthe current code
  either emits `--enable-prometheus-metrics=true` or nothing at all
  (making it `true` once again).
- The `http` container port is actually a `metrics` port (by convention
  from .e.g. webhook), but is present regardless of whether Prometheus
  metrics are enabled or not. To make it less confusing, this PR
  proposes renaming it.

Signed-off-by: Milan Plzik <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
@choisungwook @JorTurFer
Fix Remove app.kubernetes.io/instance label in crd (kedacore#556)
98da80e 
Signed-off-by: choisungwook <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@awalford16 @tomkerkhove @JorTurFer
Support crd-specific annotations (kedacore#584)
b5f1a50 
* support crd-specific annotations

Signed-off-by: Adam Walford <[email protected]>

* update readme

Signed-off-by: Adam Walford <[email protected]>

* update docs using helm-docs

Signed-off-by: Adam Walford <[email protected]>

---------

Signed-off-by: Adam Walford <[email protected]>
Co-authored-by: Adam Walford <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Update keda/templates/webhooks/service.yaml
5f9bd53 
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
move tls config the the proper section
baa6938 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member

I broke the PR trying to fix the conflict for merging it, as we want to cut a release tomorrow, I'm going to open a PR with your changes adding you as co-author @guicholeo , sorry :(

@JorTurFer JorTurFer mentioned this pull request Jan 18, 2024
Merged
3 tasks
@JorTurFer JorTurFer closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.