Fix a typo and display better msg in notes

Signed-off-by: Jirka Kremser <[email protected]>
kedacore · Apr 11, 2024 · 5c367b8 · 5c367b8
1 parent 8972cfc
commit 5c367b8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/keda/templates/NOTES.txt b/keda/templates/NOTES.txt
@@ -61,7 +61,7 @@ WARNING - Running on unsupported Kubernetes version "1.{{.Capabilities.KubeVersi
 
 {{- if .Values.serviceAccount.name }}
 -------------------------------------------------------------------------------------
-WARNING - .serviceAccount.name has been deprecated, please migrate to newest version of the Helm Chart values
+WARNING - .serviceAccount.name has been deprecated, please migrate to newest version of the Helm Chart values that allows overriding the service account name for each KEDA component
 -------------------------------------------------------------------------------------
 {{- end }}
 

diff --git a/keda/templates/manager/clusterrole.yaml b/keda/templates/manager/clusterrole.yaml
@@ -56,24 +56,23 @@ rules:
   resources:
   - '*/scale'
   verbs:
-  - get
-  - list
-  - patch
-  - update
-  - watch
+  - '*'
 {{- else }}
+- apiGroups:
+  - apps
+  resources:
+  - deployments/scale
+  - statefulsets/scale
+  verbs:
+  - '*'
   {{- range .Values.rbac.scaledRefKinds }}
 - apiGroups:
   - {{ .apiGroup | quote }}
   resources:
   - {{ .kind | quote }}
   - {{ printf "%s/scale" .kind | quote }}
   verbs:
-  - get
-  - list
-  - patch
-  - update
-  - watch
+  - '*'
   {{- end }}   
 {{- end }}
 {{- end }}

diff --git a/keda/templates/manager/poddisruptionbudget.yaml b/keda/templates/manager/poddisruptionbudget.yaml
@@ -9,7 +9,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
   {{- end }}
   labels:
-    app.kubernetes.io/name: {{ .Values.serviceAccount.name }}
+    app.kubernetes.io/name: {{ .Values.operator.name }}
     {{- include "keda.labels" . | indent 4 }}
 spec:
   {{- if .Values.podDisruptionBudget.minAvailable }}

diff --git a/keda/templates/webhooks/poddisruptionbudget.yaml b/keda/templates/webhooks/poddisruptionbudget.yaml
@@ -10,7 +10,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
   {{- end }}
   labels:
-    app.kubernetes.io/name: {{ .Values.serviceAccount.name }}
+    app.kubernetes.io/name: {{ .Values.webhooks.name }}
     {{- include "keda.labels" . | indent 4 }}
 spec:
   {{- if .Values.podDisruptionBudget.minAvailable }}