Aspect based proto impl #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kczulko
added a commit
that referenced
this pull request
Aug 11, 2024
* Update elm to 0.19.1 - getting rid of elmi files in flavor of tests detection - usage of bzlmod for elm-test example - rules_js explicit dependency added - no more implicit, hardcoded 'node' attribute for elm_test * working elm_binary rule with elm 0.19.1 * fix elm-todomvc to be 0.19.1/rules_js compatible * cleanup vol1 * MODULE.bazel.lock files removed * Fix bazel integration tests. * Fix elm-proto test * Update github workflow * Use macos-latest * Debug macos failures * Fix macos elm compiler uris * Fix checksum * Enable all tests * Debug macos failure * Use gcc14 * Fix expected output * Optional uglifyjs output * Enable all tests * absl compilation issue fix attempt * Add bazel7 integration tests * Workflow bazel7 shell fix attampt1 * Potentially fix bazel7 build * Run workflow on PR only * Upgrade checkout action and enable bazel6 it tests * Improve bazel7 overlay formatting * Blank lines removal * Fix proto generation * Bazel7 failures (execvp) fix attemp * CI fix - attempt2 * Use pure env * Add libtool * Isolate macos failure * macos ci fix attempt * Attemp 5 * Attempt 6 * attempt 7 * ci fix attempt 7 * attempt 8 * attempt 9 * Attempt 10 * Remove libtool * attempt 11 * attempt 12 * attempt 12 * attempt 13 * attempt 13? * Use proto toolchain resolution to avoid osx proto compilation * update flake.nix * update flake.nix attempt2 * Enable all tests * nix formatting * better toolchain names * Add osx x86_64 CI platform * Aspect based proto impl (#22) * Aspect based proto impl * Cleanup * Pass elm_opt via proto toolchain * elm_proto_library aspect impl * Fixes: - docs added - readme updated - bit more complex protoc test added; including well-known-protos * Update .bazelrc * Fix examples/elm-proto/foo/Spec.elm * Fix expected output * Fix tests recognition List.map removed due to Elm's strict typing * Spec.elm cleanup * Add edge testcase * Remove elmi arg from compile.py script * Fix remaining TODO's * nodejs/uglify-js annotation removal * cleanup * cleanup * Fix typo * Add bzlmod/legacy installation info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.